scottish-government-design-system / design-system

Design System for the Scottish Government and other Scottish public sector bodies
https://designsystem.gov.scot
MIT License
25 stars 11 forks source link

SELECT element errored state #3

Closed DavidChristiansen closed 9 months ago

DavidChristiansen commented 3 years ago

I believe the select's errored state should be #{$pl_prefix}select--error

jsutcliffe commented 3 years ago

Hi -- is the rationale for this that you find it strange that we use the ds_input--error class for select elements? I'm not convinced that duplicating that style to a different class is the answer, just because of having to make sure they stay in sync. A couple of alternatives that might work: