Keep highlighting keys as long as they are held

[GoogleCodeExporter]

Hi,

Problem description:
====================
key-mon seems to react only to key press, but not key release events.

Request:
========
I propose that instead, key-mon should un-highlight a key only after it is 
actually released.

Rationale:
==========
I use key-mon to teach people how to use the command line. A succession of key 
combinations which I frequently use on the command line is:
  Ctrl+C, Ctrl+D
to first end an active process and then exit the shell. In practice, I keep 
holding the Ctrl key throughout this process, so it is really more like
  Ctrl+C+D
However, key-mon highlights the Ctrl key only for a limited time, and my 
audience therefore sees something different than what I am actually doing.

best,
flo.H

Original issue reported on code.google.com by fhollerweger01@qub.ac.uk on 2 Dec 2010 at 2:04

[GoogleCodeExporter]

Thanks for the bug report.

Actually your reasoning isn't quite right - it does look at key releases as 
well. 

It looks like what happened was that I introduced a new bug.  I made an 
'enhancement' which ended up causing this bug which I didn't discover until you 
told me!  Previously if you did a control+c, and then released one of the keys 
a little bit earlier I found it distracting that they would disappear at 
different times, so the enhancement was to make them disappear at the same 
time.  

It works some of the time, but the Ctrl+C+D case it definitely fails, also the 
Ctrl key starts acting weird for a while.

This is a pretty bad bug, I'll get to it as soon as possible, but X-mas season 
is a little harder.

Thanks again.

Original comment by scottaki...@gmail.com on 3 Dec 2010 at 12:57

• Changed state: Accepted

[GoogleCodeExporter]

I fixed this in 
<http://code.google.com/r/livibetter-key-mon/source/detail?r=50fe6f013b36d9a297e
9994e941c19a5f89b4ace&name=original>

I think it works fine, didn't find any new bug after fixed this issue. 
Actually, I did, if press Ctrl+C+D quick, meaning C is still displayed, then 
switch to D key. Then D key image will blink once.

So, I added `self.countdown = None` to `_switch_to()`, it seems to fix the 
problem.

Original comment by livibet...@gmail.com on 29 Jul 2011 at 12:11

[GoogleCodeExporter]

Original comment by sc...@forusers.com on 2 Aug 2011 at 10:10

• Changed state: Fixed

[GoogleCodeExporter]

The fix wasn't committed, now it is at r26d99aa6fc. It was a re-commit because 
I named a lame named branch.

The link above would be 404 soon, I am deleting my clone.

Original comment by livibet...@gmail.com on 11 Aug 2011 at 7:12

[GoogleCodeExporter]

This issue was closed by revision 26d99aa6fc69.

Original comment by livibet...@gmail.com on 11 Aug 2011 at 7:16