scottkirkwood / key-mon

Automatically exported from code.google.com/p/key-mon
Apache License 2.0
141 stars 38 forks source link

"Old Keys" feature broken (v1.5.1+) #74

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Change the setting for how many old keys to show (Settings -> Buttons -> Old 
Keys)
2. Try the new setting

In key-mon 1.5.1, changing the setting for "Old keys" seems to be accepted only 
after a restart of key-mon. And even then, it does not work for me as expected. 
The "0" setting works as expected, but for the "1", "2", "3", and "4" settings, 
I get somewhat unpredictable results. In general, up to six old keys are 
visible for all those settings, but the settings differ in terms of which meta 
keys are visible ar startup of key-mon, and which meta-keys are "overwritten" 
by old keys when typing.

Sorry, this is somewhat vague, but the main message is that the "Old keys" 
setting seems to be broken on my Debian machine using key-mon 1.5.1. I cannot 
recall this being an issue with the same key-mon version before my latest 
system upgrade, so maybe it's related to the X version?

best,
flo.H

Original issue reported on code.google.com by fhollerweger01@qub.ac.uk on 14 Mar 2011 at 11:11

GoogleCodeExporter commented 9 years ago
I can reproduce this bug on Gentoo Linux 64-bit, with Python 2.7.1 and 
python-xlib-0.15_rc1.

Tested key-mon version 1.5.1; didn't test other versions.

Original comment by denilsonsa on 20 Apr 2011 at 3:58

GoogleCodeExporter commented 9 years ago
[deleted comment]
GoogleCodeExporter commented 9 years ago
Fix config problem and buttons add problem.

Original comment by mozbug...@gmail.com on 27 May 2011 at 10:35

Attachments:

GoogleCodeExporter commented 9 years ago
Will also need to fix for backgroundless option, I wasn't aware of this feature 
at that moment of implementing bgless.

Original comment by livibet...@gmail.com on 13 Aug 2011 at 3:23

GoogleCodeExporter commented 9 years ago
A quick note:

  * Change only takes effective when set in Settings.
  * Restart will still get no old key buttons even old key setting is stored.
  * Command line option `--old-keys` has no effects.

(@Comment 3, the patch can't be applied clearly. I will just fix by myself.)

Original comment by livibet...@gmail.com on 13 Aug 2011 at 3:30

GoogleCodeExporter commented 9 years ago
My mistake, it's already been applied at r39e3640641ff.

But, why is it still broken?

Original comment by livibet...@gmail.com on 13 Aug 2011 at 3:35

GoogleCodeExporter commented 9 years ago
My second mistake, I should have pressed some keys.

It works, just when the key-mon starts, it only shows one. The old keys will 
show up when there are old keys.

Time to fix the bgless option.

Original comment by livibet...@gmail.com on 13 Aug 2011 at 3:46

GoogleCodeExporter commented 9 years ago
This issue was closed by revision 11846399e52f.

Original comment by livibet...@gmail.com on 13 Aug 2011 at 6:27