scottlamb / moonfire-nvr

Moonfire NVR, a security camera network video recorder
Other
1.22k stars 137 forks source link

config tool: improve camera dialog validation #152

Closed scottlamb closed 3 years ago

scottlamb commented 3 years ago

From #151:

  1. RTSP Url setup - the config asks for the host, user and password and a url. I initially entered the url with username/password but when starting the server (nvr run) I got no open port on 8080. After figuring out how to see the logs I got a long stack trace that started with an exception complaining that the url should not include the username/password. So I changed the url to just the path, i.e. /Streaming/Channels/101, still no joy, now complaining about a relative url. I finally figured out that it needs the url with the scheme and host, but not the username/password. This should be picked up when entering it in the config, not with an exception at run time. And...

  2. Similarly to 3, if I don't set a sample directory the config dialog is quite happy but an exception is thrown at run time.

I think both of these can be addressed by improving validation in that dialog.