scottlamb / moonfire-nvr

Moonfire NVR, a security camera network video recorder
Other
1.2k stars 138 forks source link

Update build.md #186

Closed bmsleight closed 2 years ago

bmsleight commented 2 years ago

Missing a mkdir $HOME/bin

scottlamb commented 2 years ago

If $HOME/bin doesn't exist, it's also probably not in $PATH, so the nvr init command a couple lines down will fail.

This doc is supposed to be aimed at pretty savvy folks and says "This document doesn't spell out as many details as the installation instructions." So I don't want it to go on a long tangent about how to set up your $PATH in all the various shells folks might use. Still, maybe it's worth adding one sentence reminding to check $PATH if that command fails, even linking to a guide if you can find a good one. What do you think?

bmsleight commented 2 years ago

Good idea.

I am pulling my notes together on a build from source on a PI 3 - I can do a separate page on the wiki which could be used as a reference ? This could have more detail such as check check $PATH.

On Mon, 10 Jan 2022 at 05:41, Scott Lamb @.***> wrote:

If $HOME/bin doesn't exist, it's also probably not in $PATH, so the nvr init command a couple lines down will fail.

This doc is supposed to be aimed at pretty savvy folks and says "This document doesn't spell out as many details as the installation instructions." So I don't want it to go on a long tangent about how to set up your $PATH in all the various shells folks might use. Still, maybe it's worth adding one sentence reminding to check $PATH if that command fails, even linking to a guide if you can find a good one. What do you think?

— Reply to this email directly, view it on GitHub https://github.com/scottlamb/moonfire-nvr/pull/186#issuecomment-1008558526, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA4VSNOZCFXXEXUIQ3VZA53UVJWO7ANCNFSM5LSNWXXQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you authored the thread.Message ID: @.***>

scottlamb commented 2 years ago

A reference on the wiki sounds great!

bmsleight commented 2 years ago

Superseded by https://github.com/scottlamb/moonfire-nvr/pull/190