scottlamb / moonfire-nvr

Moonfire NVR, a security camera network video recorder
Other
1.2k stars 138 forks source link

Do not check for video codec by checking SDP video parameters #191

Closed valpackett closed 2 years ago

valpackett commented 2 years ago

Since retina now supports in-band parameters, we should only check the media type for this.


Basically https://github.com/scottlamb/retina/issues/43#issuecomment-983223883 but here ;)

Together with https://github.com/scottlamb/retina/pull/50 this makes the Dafang with CFW work. (Same CFW on the Xiaofang did not have the issue, the difference in stuff returned by the hardware encoders causes this difference.)