search

scottlamb / moonfire-nvr

Moonfire NVR, a security camera network video recorder
Other
1.19k stars 138 forks source link

Use merge commit on bpaf master instead of deleted feature branch. #259

Closed tim-seoss closed 1 year ago

tim-seoss commented 1 year ago

Just a small PR to fix a build error (bpaf github have deleted the referenced feature branch, and merged to main).

scottlamb commented 1 year ago

Interesting. I'd assumed what I did before was stable because there was a specific commit referenced in Cargo.lock. But I can reproduce the error you're referring to...

[slamb@nuc ~/git/moonfire-nvr/server]$ cargo build
    Updating git repository `https://github.com/pacak/bpaf.git`
error: failed to get `bpaf` as a dependency of package `moonfire-nvr v0.7.5 (/home/slamb/git/moonfire-nvr/server)`

Caused by:
  failed to load source for dependency `bpaf`

Caused by:
  Unable to update https://github.com/pacak/bpaf.git?branch=exit_code#5238a606

Caused by:
  object not found - no match for id (5238a6069abca0d61cf1c000e56bbac946e7ee18); class=Odb (9); code=NotFound (-3)

...even though that commit seems to exist in the repo: https://github.com/pacak/bpaf/commit/5238a6069abca0d61cf1c000e56bbac946e7ee18

If I switch to using rev = "5238a6069abca0d61cf1c000e56bbac946e7ee18", then it works. I guess I'll avoid using a Cargo.toml branch in the future.

Anyway, there's a new packaged release, so I'd like to use that. I've got another bpaf cleanup anyway, so I can take care of this.

scottlamb commented 1 year ago

0ffda11 should take care of this.