search

scottlawsonbc / audio-reactive-led-strip

:musical_note: :rainbow: Real-time LED strip music visualization using Python and the ESP8266 or Raspberry Pi
MIT License
2.68k stars 644 forks source link

Marty edit led.py #270

Closed brisbaneroboticsclub closed 4 years ago

joeybab3 commented 4 years ago

It seems that this PR just edits the defaults in config.py. Please leave all defaults the same when creating PRs. As for the other changes, it seems you just add an int cast to fix a bug? Let me know what exactly this PR aims to solve and I can merge it.

brisbaneroboticsclub commented 4 years ago

Agree, the config file just changes the settings. As you can see the DMA is in original strandtest is 10, also the display looks better without being inverted... I thought the code or neopixels were faulty.

The int() fixes issue 174... When i installed rip_ws281.git i needed a python3 version to run with my other python3 code. the int() fixes the uint32 error.

https://github.com/scottlawsonbc/audio-reactive-led-strip/issues/174

joeybab3 commented 4 years ago

I understand that it might look better in your setup but at the moment Scott prefers to keep the defaults he has set so I intend to follow that precedent. The int cast can be merged as that should solve the issue you mentioned.