search

scottmac / opengraph

Helper class for accessing the OpenGraph Protocol
463 stars 151 forks source link

Add support for twitter cards #25

Closed martinstuecklschwaiger closed 8 years ago

martinstuecklschwaiger commented 8 years ago

It's only a small change and would not break the rest of the functionality in any way.

@AramZS thanks for your work on this library!

AramZS commented 8 years ago

Hi @martinstuecklschwaiger I figured out why I couldn't get this to work, Twitter advises its tags be set with name instead of property so I couldn't get Twitter tags on any pages the library was directed at. https://dev.twitter.com/cards/types/summary-large-image

I've added code to check there for Twitter values and it works great now. I've added it to my forward master branch. Thanks!

martinstuecklschwaiger commented 8 years ago

Thanks a lot. I'll close this PR then…