scottmckendry / cyberdream.nvim

🤖💤 High-contrast, Futuristic & Vibrant Coloursheme for Neovim
MIT License
606 stars 25 forks source link

[Feat]: more colour distinction #69

Closed AlejandroSuero closed 2 months ago

AlejandroSuero commented 2 months ago

Question or Suggestion

I am currently using astrotheme but I discovered this theme and I loved it, but the problem is, that all seems the same colour, hard to distinguish the type of variables.


As you can see, booleans have their own colour and accessing a variable member as well.

The highlight groups affected in this group, using :Inspect in the other colorschemes, are:

How cyberdream is currently:

In the case that this is the intended colour palette, at least exposing a function to override or add highlights would be a good start.

AlejandroSuero commented 2 months ago

A little preview of adding more distinction (the palette and colours chosen can be change):

https://github.com/scottmckendry/cyberdream.nvim/assets/71392160/9e70aff2-e52a-4888-896f-c01e12908d98

If you want me to do a PR about it @scottmckendry, with a more defined colours to use for the different scenarios, like for example this minimal change:

Screenshot 2024-06-14 at 12 34 53
AlejandroSuero commented 2 months ago

I started doing a little override function to showcase what I meant for that, as maybe confusing having a highlights entry on theme.

override function

The function will give you the ability to use the colour palette instead of hard coding colours.

scottmckendry commented 2 months ago

Thanks for raising this @AlejandroSuero !

You aren't the first one to ask for this, and I think you're right, I think we should add in a couple of new defaults to separate booleans, variables, properties etc.

I like the look of this one here (to start):

image

Are you happy to open another PR to get this rolling?

AlejandroSuero commented 2 months ago

@scottmckendry yeah, I can do it. Should we keep this issue open? (to include closes # (issue) or not)