scottmckendry / cyberdream.nvim

🤖💤 High-contrast, Futuristic & Vibrant Coloursheme for Neovim
MIT License
697 stars 29 forks source link

Add highlight for WinSeparator #8

Closed fingolfin19 closed 9 months ago

fingolfin19 commented 9 months ago

Nvim is deprecating VertSplit and moving to WinSeparator for borders in 0.10. By default, WinSeparator links to normal which does not look great for most colorschemes.

scottmckendry commented 9 months ago

Thanks for the issue. Do you have some more info on the deprecation or maybe an example of where you're seeing wrong highlights?

I've not tested cyberdream with 0.10 yet but I can confirm that the WinSeperator group is set.

fingolfin19 commented 9 months ago

Thanks for the issue. Do you have some more info on the deprecation or maybe an example of where you're seeing wrong highlights?

I've not tested cyberdream with 0.10 yet but I can confirm that the WinSeperator group is set.

Ah, there's a typo in your file. It's WinSeparator, not WinSeperator.

Here's a screenshot:

image

scottmckendry commented 9 months ago

Well, that's a bit embarrassing! I've fixed the typo in the latest commit. Thanks again!

cybergaz commented 5 months ago

windows separation is non-existent even after setting up WinSeparator = { fg = "#50505e", bg = "" }

1714504850

scottmckendry commented 5 months ago

@cybergaz there's an override for this in the config - hide_fillchars that sets these to " " when true. https://github.com/scottmckendry/cyberdream.nvim/blob/d777f1bfb0e6e1d74b3f243d8e4999b6b931ae19/lua/cyberdream/theme.lua#L18C4-L29C9

Setting this to false will change them back to the default.

cybergaz commented 5 months ago

thx... that solved it

but may i ask what's the point of these hide fillchars??

scottmckendry commented 5 months ago

Preference. To me, fill chars are extra visual clutter. But not everyone sees it that way, which is why I added the option 😉