search

scottmsul / FactorioQualityOptimizer

Optimizes prod/quality module ratios for creating high-quality products in Factorio
MIT License
12 stars 4 forks source link

Add nix flake and some restructuring for poetry compatability #2

Closed Daholli closed 1 week ago

Daholli commented 1 week ago

Heyho, found the tool really interesting but since it did not run out of the box on my machine I set it up so it would, feel free to merge if you want to.

PS: please add a license as otherwise the default license is pretty strict (unless that is what you want)

Daholli commented 1 week ago

@scottmsul can you have a look and see if this is something that would be ok with you?

scottmsul commented 1 week ago

Hi Daholi,

I looked through the PR, and I appreciate the thoughts and suggestions. Since I do not use nix flakes or poetry I would prefer not to have these extra dependencies checked into the codebase. However, I did add an MIT license, switched to the default arg formatter, moved the main code into a main function, and added pycache to the .gitignore.

Daholli commented 1 week ago

Alright then I will try to maintain the flake