Perl::Critic Severity 2 Issues

[scottoffen]

Fix issues related to the following Perl::Critic severity 2 violations:

• Prohibit Stringy Split
• Prohibit C Style For Loops
• Require Checked Close
• Prohibit Double Sigils
• Prohibit Fixed String Matches
• Prohibit Ampersand Sigils
• Prohibit Empty Quotes
• Prohibit Noisy Quotes
• Prohibit Punctuation Vars

Granted, these are all based on one persons opinions about how Perl should be written, so allowances were made in some places by adjusting the Perl::Critic profile being used. In the comments on this issue I'll include notes about the errors I ignored.

[scottoffen]

Prohibit Postfix Controls and Prohibit Unless Blocks and Prohibit Until Blocks

The use of Postfix controls - especially unless - are one of my favorite things about Perl. IMHO, my use of them does not make the code any more difficult to understand, and readability is the only reason these controls are brought into question.

Require Pod Links Include Text and Require Pod Sections

Issue #2 has been logged for all documentation issues.

Require Dot Match Anything and Require Line Boundary Matching

I've check all cases reported - all 79 and 74, respectively - and have determined that these modifiers are not required.

• Metaphor::BaseX
• Metaphor::Config
• Metaphor::Logging
• Metaphor::Mailer
• Metaphor::REST
• Metaphor::Scripting
• Metaphor::Simplify
• Metaphor::Storage
• Metaphor::Tripcode
• Metaphor::Util

Prohibit Magic Numbers

I'm leaving the 21 instances that are left. They apply directly to positioning and length that is self explanatory in context.

• Metaphor::Logging
• Metaphor::Mailer
• Metaphor::Storage
• Metaphor::Util