search

scottohara / loot

An implementation of some of the core MS Money features in Ruby on Rails
MIT License
4 stars 3 forks source link

Build failure due to Firefox bug in Function.prototype.toString() #118

Closed scottohara closed 4 years ago

scottohara commented 7 years ago

Angular issue: https://github.com/angular/angular.js/issues/14240 Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1216630

After removing babel build step, test suite passes locally (Chrome) but fails in Travis (Firefox) with Class constructor Controller cannot be invoked without 'new'

The issue is that Angular tries to detect whether a Controller is a function or class (i.e. $injector.isClass()), but when stringified, Firefox converts class Foo {} to function Foo() {}.

scottohara commented 7 years ago

As of 9-Jun-2017, we have switched from Chrome to ChromeHeadless in test:src and test:build, and have temporarily removed Firefox (and all xvfb config) from .travis.yml.

Leaving this task open, as we would like to have the test suite run against Firefox 55 (which contains the above fix), and ideally when Firefox Headless is supported (i.e. MOZ_HEADLESS=1 /path/firefox) we can do this without requiring xvfb.

scottohara commented 4 years ago

Migrated from Travis to GitHub actions, so this is no longer applicable