scottohara / loot

An implementation of some of the core MS Money features in Ruby on Rails
MIT License
4 stars 3 forks source link

ngtemplate-loader broken by html-loader@1.0.0 #182

Closed scottohara closed 3 years ago

scottohara commented 4 years ago

Currently we're pinned to html-loader@0.5.5 while waiting for this to be merged/released:

https://github.com/WearyMonkey/ngtemplate-loader/pull/86

When we eventually can upgrade to html-loader@1.1.0, the config needs to change to this:

{
  loader: "html-loader",
  options: {
    attributes: {
      list: [
        ...,
        { attribute: "typeahead-template-url", type: "src" }
      ]
    },
    minimize: false
  }
}

When testing this change, check whether minimize: false is needed (its now true by default for production mode in 1.x, but its not clear whether minimize will work with partial templates)