search

scottopolis / edd-metrics

EDD Metrics
46 stars 12 forks source link

Use standard EDD functions for number formatting. Fixes #14 #29

Closed Netzberufler closed 7 years ago

Netzberufler commented 7 years ago

By using the standard edd_currency_filter() and edd_format_amount() functions the currency numbers are formatted with the EDD settings for currencies. This includes currency position, thousands separator and decimal separator (Currency Settings can be found on EDD > Settings > General > Currency Settings).

The first commit removes the hard coded currency sign in the admin.js. I have not minified the admin.min.js, so this has to be done before the next release.

scottopolis commented 7 years ago

This looks good, thanks so much! I'll add the minified js file.

scottopolis commented 7 years ago

What's your .org username? I'll add you to the contributors.

Netzberufler commented 7 years ago

You're welcome. EDD Metrics is an awesome plugin and was on my wish list for a long time. Thanks so much for creating it.

You can add my personal .org account if you want: https://profiles.wordpress.org/netzberufler/