search

scottpchow23 / runekit

Alt1-compatible widget host for RuneScape 3
GNU General Public License v3.0
2 stars 0 forks source link

Clue solver stopped working #5

Open laurenswuyts opened 3 years ago

laurenswuyts commented 3 years ago

Since yesterday my clue solver doesn't work anymore:

ERROR:runekit.app.view.browser_window.PageClass.https://runeapps.org/apps/clue/:Uncaught (in promise) IndexSizeError: Failed to construct 'ImageData': The source width is zero or not a number.

whs commented 3 years ago

There's a bug with this line where it should be ...args. I reported the bug to Skillbert and he said it is fixed but not deployed.

The real alt1 does implement captureMultiAsync so that codepath is used instead. I implemented the API in 8eab6d9d21e95928267f106cc30f6722231e943f and can confirm that Clue Solver is now working.

schoentoon commented 3 years ago

I had this same issue recently. I ended up just commenting out https://github.com/whs/runekit/blob/master/runekit/browser/alt1.js#L363-L378 before running, did however not commit this to my fork as it doesn't seem like a proper fix.