scottrice / Ice

Application to automatically add ROMs to Steam
http://scottrice.github.io/Ice/
MIT License
835 stars 96 forks source link

Problem with Consolegrid API? #115

Closed Jabnin closed 10 years ago

Jabnin commented 10 years ago

Without doing anything to config.txt, Ice stopped downloading grid icons and gave me the following error image

The site is up, so did I do something dumb, or is the API busted?

scottrice commented 10 years ago

Looks like a problem with Ice, as ConsoleGrid seems to be responding fine to all of the requests I am sending it.

That specific error appears if a request to download a grid image fails, but I dont actually log any data about it. Are you running this from source (ice.py) or executable (Ice.exe)? I will add some better logging for this error tonight and that will hopefully lead us in the direction of a fix.

scottrice commented 10 years ago

I think I just realized what the problem is. Would you mind posting the contents of your consoles.txt file?

Jabnin commented 10 years ago

image

scottrice commented 10 years ago

Sorry I should have been clearer. That is your config.txt, I am looking for consoles.txt, which should have your entries for Nintendo 64, Playstation, etc.

Jabnin commented 10 years ago

Aw geez. I skimming and jumped the gun a bit.

[Nintendo Entertainment System] nickname=NES emulator=NEStopia

[Super Nintendo] nickname=SNES emulator=SNES9X

[Nintendo 64] nickname=N64 emulator=Project64

[Nintendo Gamecube] nickname=Gamecube emulator=Dolphin

[Nintendo Wii] nickname=Wii emulator=Dolphin

[Playstation 1] nickname=PS1 emulator=

[Playstation 2] nickname=PS2 emulator=

[Sega Genesis] nickname=Genesis emulator=

[Sega Dreamcast] nickname=Dreamcast emulator=

[Nintendo Gameboy] nickname=Gameboy emulator=VBA

[Gameboy Advance] nickname=GBA emulator=VBA

[Nintendo DS] nickname=DS emulator=DSemu

scottrice commented 10 years ago

Ok, I figured out the issue. The issue is with partly with ConsoleGrid, and partly with my code.

The issue is that, when I made ConsoleGrid, users couldnt add their own consoles to Ice. That meant I had a very short list of possible consoles to go by, and I was able to ensure that the nickname for the console was the same nickname that Ice used.

This changed when I added the ability to do custom emulators and custom consoles. This meant that Ice was sending a console nickname that ConsoleGrid had never heard of, and ConsoleGrid was sending back an error because of it. Ice also detects if ConsoleGrid is down by seeing if it returns 500 errors after a request. Ice saw the 500 error from sending it the Nintendo DS nickname and assumed ConsoleGrid was no longer operational, so it stopped making requests.

The fix to this is to either A) Make Ice just skip the console if it gets a 500 or B) Make ConsoleGrid handle nicknames it hasn't heard of more gracefully. I think I will probably do both.

Jabnin commented 10 years ago

I know you mentioned before not adding Wii to Consolegrid, is there a particular reason? I'm a fan of cataloging and could definitely add games and banners over time as I find them.

scottrice commented 10 years ago

Its not that I am against adding it, it is just that in the future ConsoleGrid will not be where Ice gets its images. I talked to the guys over at thegamesdb.net and they are planning on implementing steam grid images for the games on the site. When that happens, I plan on switching Ice over to using their data as opposed to ConsoleGrid (as they run a much better website than I do). Since ConsoleGrid has a limited lifetime, I am cautious of putting in too much work.

That being said, ConsoleGrid has been left behind by Ice. Its not just Wii, but since people can add consoles themselves, ConsoleGrid needs to step up. What I really need to do is add the ability to create consoles. I probably don't want to do that for any user though, as there aren't enough consoles to warrant giving everyone the ability to make new ones at will.

Jabnin commented 10 years ago

Ahhhh, okay. That makes sense.

ghost commented 10 years ago

Hi,

I'm experiencing this problem, but I haven't changed the Default nicknames as provided in the Consoles.txt document. I am using emulators I have picked though.

My library is quite large - the SNES and Genesis collections number 400 together - could this be an issue? Is there a way to scan each console at a time?

I'm running Ice from the executable, Python 2.7.6 (64bit) is installed, and Ice resides in my SteamApps folder.

Thanks

scottrice commented 10 years ago

Ok, I added Wii and DS to ConsoleGrid, which should solve the problems that you guys are having. Let me know if it continues. Also, if you have any other suggestions for things to add to ConsoleGrid, feel free to post them here: http://steamcommunity.com/groups/IceRM/discussions/0/666826251248041382/

scottrice commented 10 years ago

@colourofsound I should have waited for your response before I closed the issue, but did you perhaps add a Nintendo DS emulator? If so, that is most likely your problem. Try running Ice again and see if it works

weblets commented 8 years ago

I have similar problems with Atari 5200 and the Wii Virtual Console