search

scottrice / Ice

Application to automatically add ROMs to Steam
http://scottrice.github.io/Ice/
MIT License
834 stars 96 forks source link

Ice does not work with higan/icarus v095 #308

Open ghastmask opened 8 years ago

ghastmask commented 8 years ago

Basically icarus now creates a folder for each rom "Foo.fc" for famicom "Foo.sfc" for super famicom. The ROMFinder calls files_in_directory, which filters out directories.

As a temporary workaround I patched filesystem.py file_in_directory to also return subdirectories. I then changed rom.py to check if self.extenions == "" and os.path.isfile(path) return True.

This way by default subdirectories won't be matched unless you specify an extension. Seems like a hack but it got it working.

xeroxpickles commented 8 years ago

Can you post the exact code of rom.py? My python knowledge is pretty limited, so I'm having trouble figuring out where you put if self.extenions == "" and os.path.isfile(path) return True

ghastmask commented 8 years ago

Yeah I will post the code tomorrow night or this weekend.

On Nov 4, 2015, at 3:54 PM, xeroxpickles notifications@github.com wrote:

Can you post the exact code of rom.py? My python knowledge is pretty limited, so I'm having trouble figuring out where you put if self.extenions == "" and os.path.isfile(path) return True

— Reply to this email directly or view it on GitHub.

ghastmask commented 8 years ago

I pushed the patch to my fork: https://github.com/ghastmask/Ice/commit/020977fef804fbbec6a6d93d27704da656c256ab

cpence commented 8 years ago

Also having the same issue. For more info, you can check out the game paks page on the higan website; the "file extensions" are still the same (intending to retain cross-compatibility for cases like this), but obviously the file search now needs to match folders. Would love to see this patch integrated!