scottrice / Ice

Application to automatically add ROMs to Steam
http://scottrice.github.io/Ice/
MIT License
834 stars 96 forks source link

Find a way to gracefully allow Steam to be closed on SteamOS #346

Open mdeguzis opened 8 years ago

mdeguzis commented 8 years ago

Long shot, but now that you have accepted our changes from our fork that tells you actually what is blocking ice from running, there needs to be some sort of way to gracefully exit steam or continue past it. Not sure if you have any ideas:

steam@steamos:~$ ice-launcher 
=========== Starting Ice ===========
Ice cannot run because of issues with your system.

* `steamwebhelper` cannot be running while Ice is being run

Please resolve these issues and try running Ice again

Close the window, or hit enter to exit...
scottrice commented 8 years ago

So before anything else I can add a CLI flag like --skip-steam-check which will let you continue running even if Steam is open. Be careful though - the reason this check exists is because Steam writes its shortcuts.vdf file on close, so if Ice is run while Steam is open when Steam closes (which will need to happen to view shortcuts) it will overwrite anything you did.

On the other hand, one of the big features that I REALLY want to add is to allow you to update Ice from Steam. Like, you have a shortcut which is basically "Run Ice" that will close Steam, run Ice to sync your shortcuts, then open Steam again. I have a feeling that running //after being launched from Steam// will present its own challenges - I doubt I can just close Steam while running a Steam shortcut, but I have nothing to back that thought up and havent investigated at all. Still, in the meantime I bet I can figure out how to make Ice automatically stop and restart Steam.

mdeguzis commented 8 years ago

Interesting thoughts. I will be front and center to test anything for SteamOS. I'll ponder of some of these points today. I just got a dog last friday, so time comes in short spurts. Thank you Scott.

scottrice commented 8 years ago

Also @ProfessorKaos64 I remember you or @sharkwouter mentioned that you wanted a way to turn off downloading images from consolegrid (cause of running Ice as part of the startup path). I added a way to do that in a86619bff89db80a87c7bca47b9a609528cfea2c, which I use mostly for integration tests.

mdeguzis commented 8 years ago

Something like that yes, or that the intended behavior would be to pull from the custom directory, and fill in the gaps for the rest. I believe that is what your code does though, in the gridproviders python code. Let's let @sharkwouter weigh in for his opinion as well. The skip steam check is great, which i'll have to run some tests on. If the Ice shortcuts then go away if ran while Steam is open, then closes, we won't likely use it, but it is very useful for testing, so I appreciate it from a debug standpoint. Commit a86619b is very welcome as well.

Soon enough, this may be compatible with SteamOS :) When we get to that point, likely a certain commit will take over as "stable" for our uses on SteamOS, with semi-daily builds as "unstable" At the moment, we have ice-steamos , and semi-daily builds of this master tree as "ice-unstable".