Add Python 3 compatibility

scottrice / Ice

Application to automatically add ROMs to Steam

http://scottrice.github.io/Ice/

MIT License

835 stars 96 forks source link

Add Python 3 compatibility #362

Open RobLoach opened 8 years ago

RobLoach commented 8 years ago

Aim is to allow running in either Python 2 or 3. Still some things missing:

[ ] PySteam Python 2/3 Compatibility
[ ] Fix return sum(map(self.roms_for_console, consoles), []) in rom_finder.py since map() now returns an iterator
[ ] Check if if not instances in settings.py in Python 3 actually works on map() iterators
[ ] See what's missing from https://github.com/scottrice/Ice/pull/268

Would appreciate some testing, et al.

scottrice commented 8 years ago

I know I said it on the pysteam pull request as well, but thanks for doing this. I'll try to take a look sometime soon. The big thing I need to solve before I merge this is I need to figure out how to make sure I dont break it as soon as I write another line of code :P.

RobLoach commented 8 years ago

Agreed, making sure the compatibility works in Pysteam is the first step. I saw some work had gone into this before as well.