search

scottrice / Ice

Application to automatically add ROMs to Steam
http://scottrice.github.io/Ice/
MIT License
834 stars 96 forks source link

Periods in ROM filenames yield incorrect shortcut names #364

Closed drglove closed 8 years ago

drglove commented 8 years ago

Commit: https://github.com/scottrice/Ice/commit/5000749fd68c6fa7356ad38a75d148527d216ef6 When a ROM contains a '.' in the filename, it seems that the parsing of the filename stops. For example, Dr. Mario 64.z64 puts the shortcut name as Dr with no text following.

I would suspect that it is trying to strip off the extension but this is being handled incorrectly.

drglove commented 8 years ago

It looks like it's caused by the regex string used here: https://github.com/scottrice/Ice/blob/5000749fd68c6fa7356ad38a75d148527d216ef6/ice/parsing/rom_parser.py#L10-L15

scottrice commented 8 years ago

Ah, good find. Thanks for the report! Adding an example name also helps a lot, I'll work on getting this fixed.

drglove commented 8 years ago

Looks good @scottrice, can I close my pull request https://github.com/scottrice/Ice/pull/365?