scottrice / Ice

Application to automatically add ROMs to Steam
http://scottrice.github.io/Ice/
MIT License
837 stars 96 forks source link

Error in function should_use_user_override #468

Open Cybso opened 7 years ago

Cybso commented 7 years ago

In ice/cli/runner.py:

  def should_use_user_override(self, override):
    if override is None:
      return False
    if override == "":
      return False
    if not self.filesystem.path_exists(override):
      logger.warning("config.txt specifies a Steam userdata directory that doesn't exist. Ignoring.")
      return False
    return False

If think the last line should return "True", not "False". Otherwise this method doesn't make sense.