search

scottschiller / ArmorAlley

A browser-based interpretation of Armor Alley, a combat strategy game originally released in 1990 for the Macintosh and MS-DOS PCs.
https://armor-alley.net/
Other
91 stars 25 forks source link

Clicking does not change the direction of the helicopter #3

Closed supercobra closed 1 year ago

supercobra commented 1 year ago

After some time playing, the helicopter does not change direction by clicking.

scottschiller commented 1 year ago

Thanks for this report, also. Did you happen to blur / focus / minimize the window, going back and forth between this and other tabs before this happened? It may be something has gone sideways with event handlers or logic - I feel like I ran into the click thing the other day myself, but I have yet to repro. I was in Chrome Canary on desktop.

supercobra commented 1 year ago

It was on safari playing in full screen mode.

whoisterencelee commented 1 year ago

This happened to me too, on desktop, it usually happens when I clicked and while it was changing direction, I moved the mouse out of the playing area. Then the helicopter would get stuck in that direction, after clicking slowly a few times, sometimes it would get back to normal.

scottschiller commented 1 year ago

Thank you for the detail, I'm hoping to get a consistent repro and a fix for this one. I made a change related to auto-rotate recently for mobile, but that should not have affected desktop. That said, two recent reports suggests something has happened. 😅

scottschiller commented 1 year ago

@supercobra and @whoisterencelee: I finally hit this bug in Safari! The bottom part of the game UI with the queue and options | exit links was overlapping some of the battlefield area and capturing clicks. This was likely a regression caused in fixing a long-standing text rendering issue specific to Safari.

It's illustrated here with the green border. Clicks were being "swallowed" within that area. Armor Alley - bottom UI overlay While flying, clicking within that area would have no effect. Higher up, clicking would rotate the helicopter as expected.

Side note: The game should be less blurry now in Safari at full-screen, I finally fixed a long-standing transform / scale issue affecting text rendering. Shenanigans were involved, but it works. ;) ec66d3ee13853d5a7e1f5e14f9e570739988089d

Let me know if you continue to see this or any click issues after today, and maybe with a shift + reload to ensure you've got the latest code.

supercobra commented 1 year ago

The 'click to U-turn' works well now on Safari.

scottschiller commented 1 year ago

Thanks for confirming; glad to get this one sorted.

whoisterencelee commented 1 year ago

Confirm working on desktop firefox as well, nice