search

scottschluer / geolocation

A C# class library that will calculate distance and cardinal direction between two sets of coordinates and provides the lat/long boundaries around an origin coordinate allowing for simple SQL or LINQ selection of locations within the given radius.
MIT License
203 stars 46 forks source link

Submit to NuGet #3

Closed jchristn closed 7 years ago

jchristn commented 8 years ago

Hi Scott,

Thanks for making this code public. Any interest in submitting this to NuGet? Happy to help if you're open to it!

Cheers Joel

fehro commented 8 years ago

+1 to that. NuGet package would be great.

scottschluer commented 8 years ago

If someone wants to tackle that, I'd be open to reviewing/merging a pull request. I'm swamped with my real-life job right now so I wouldn't have the time to look into adding a NuGet package for at least a couple of months.

jchristn commented 8 years ago

I forked to here: https://github.com/jchristn/geolocation

And created a NuGet package, which I submitted for you: https://www.nuget.org/packages/Geolocation/

If you want to merge on your side I'm happy to remove my fork (sorry I'm not a git super user so it wasn't readily apparent how to create a branch from your repo and then create a pull request!)

Or I'm fine managing the upload for you etc, whatever works best.

Thanks for making this helpful package!

scottschluer commented 7 years ago

Hey sorry for the lengthy delay here. Been incredibly busy. Can you create a branch on your fork? You made the changes directly to master so if you just create a new branch off of master and push it to GitHub without making any changes, you should be able to create a pull request into this repository.

scottschluer commented 7 years ago

Also, would you mind transferring ownership of the Nuget package to my nuget account so we don't lose history on it and so updates for folks who have already installed it are seamless? Account name is the same as my GitHub username: scottschluer.

To change ownership of a package, do the following:

Sign in to nuget.org with the account that is the current owner of the package. Click on your username, then on Manage my packages, then on the package you want to manage. Click the Manage owners link on the left side. From here you have several options:

To add an owner, enter their NuGet account name and click Add. This sends an email to that new co-owner with a confirmation link. Once confirmed, that person has full permissions to add and remove owners. (Until confirmed, the Manage owners page will indicate "pending approval" for that person). To remove an owner, select their name on the Manage owners and click Remove. To transfer ownership (as when ownership changes or a package was published under the wrong account), simply add the new owner, and once they've confirmed ownership they can remove you from the list.

jchristn commented 7 years ago

Hi Scott, NuGet ownership change is done

jchristn commented 7 years ago

Just created and pushed branch 'NuGet'

scottschluer commented 7 years ago

Thanks for the quick response! For some reason I'm unable to create a pull request but I'll see if I can't just incorporate the changes over here. Shouldn't be too difficult.

scottschluer commented 7 years ago

@jchristn Thanks again! We're all set. You can delete your local branches if you like.