scottstanie / sentineleof

Download Sentinel 1 precise orbit files
MIT License
97 stars 18 forks source link

Error with tuple of results when running eof #17

Closed jukesliu closed 3 years ago

jukesliu commented 3 years ago

File "/Users/jukesliu/opt/anaconda3/lib/python3.8/site-packages/eof/download.py", line 122, in download_eofs item['path'] for item in result.downloaded.values() AttributeError: 'tuple' object has no attribute 'downloaded'

scottstanie commented 3 years ago

Hi @julialiu18 , sorry about that error. I believe this is from having the older, pre-1.0 version of the sentinelsat package.

In that version, download_all returns a tuple, https://github.com/sentinelsat/sentinelsat/blob/v0.14/sentinelsat/sentinel.py#L809

But starting in 1.0 it returns a NamedTuple: https://github.com/sentinelsat/sentinelsat/blob/main/sentinelsat/sentinel.py#L812

I wish I knew a way to have the dependency upgrade automatically when you get the new version of a pip package, but I dont think that works with pip.

If you do

pip install --upgrade sentinelsat (or equivalently upgrade with conda), it should fix this problem.

jukesliu commented 3 years ago

That fixed it! Thank you.