search

scottsweb / mobble

✅ WordPress plugin that provides conditional functions for detecting a variety of devices.
http://scott.ee/journal/mobble/
Other
85 stars 19 forks source link

Not recognising iPad 3/4 #3

Closed mrjonnywood closed 10 years ago

mrjonnywood commented 10 years ago

Hi Scott,

I've been using mobble for a few years now and it's a great plugin. Many thanks for your hard work. Not sure if this is the place I should be posting this but...

I've just one question: I've used the plugin extensively on http://palmerslodges.com and all works fine other than testing on iPad 3/4 shows 'mobile' code, not 'tablet'. If you visit the domain in Chrome and change Emulation from iPad1/2/Mini to iPad 3/4 you'll see that the images are 'mobile' resolution and the booking box doesn't show. I'm using the latest version of mobble downloaded from here, even taken the latest version of mobile-detect (2.7.7) but still no luck.

This is the body class on iPad1/2: <body class="home blog logged-in handheld ios tablet ipad safari cat-170-id js-ready"

& this is it on iPad3/4: <body class="home blog logged-in handheld mobile ios iphone safari cat-170-id js-ready">

scottsweb commented 10 years ago

@mrjonnywood I just spotted this issue. How funny! For some reason email alerts seem to be disabled.

I am guessing this is still an issue?

mrjonnywood commented 10 years ago

TBH can't quite remember. Will run further tests when I'm next developing that particular site.

mrjonnywood commented 10 years ago

@scottsweb Just tested this now. Seems to be working. Probably a caching issue ;)

scottsweb commented 10 years ago

:) excellent. I will close this one then.

I have pushed an updated version of mobile detect to this repo for testing. Have not got around to testing it yet. Hoping to soon.

If something like this happens again it would be good to test the device here: http://demo.mobiledetect.net/ to see what it comes back with. If we can make the core library better then I can feel better about updating it more often.

Plans for a cache compatible version continue to tick over.