search

scottwernervt / cloudstorage

Unified cloud storage API for storage services.
http://cloudstorage.readthedocs.io/en/latest/
MIT License
93 stars 27 forks source link

Fix Blob not found when iterating over local container #82

Open habibutsu opened 3 years ago

habibutsu commented 3 years ago

Fix for https://github.com/scottwernervt/cloudstorage/issues/80

use-to commented 2 years ago

Hello everyone! I would like to push this pr! Unfortunately is the pipeline still failing - @habibutsu @scottwernervt

We all know that there is no directory concept in "normal" object storage. So after each deletion we should check if there are empty directories left. Ignoring those empty dirs could lead to bad expericences using this local storage abstraction layer. This project needs more maintenance!

zevisert commented 1 year ago

Looking for this PR today too

zevisert commented 1 year ago

@use-to I have a branch with that directory cleanup working: https://github.com/zevisert/cloudstorage/commit/a9159695b0074e4ede9cb9525f0aaeddc98269d3

If @scottwernervt shows some activity here I'll put up an MR, but for now I've just been installing cloudstorage as a git dependency - using poetry that'd look like this: 

[tool.poetry.dependencies]
cloudstorage = {git = "https://github.com/zevisert/cloudstorage.git", rev="a9159695b0074e4ede9cb9525f0aaeddc98269d3", extras = ["local", "google"]}
use-to commented 1 year ago

@use-to I have a branch with that directory cleanup working: https://github.com/zevisert/cloudstorage/commit/a9159695b0074e4ede9cb9525f0aaeddc98269d3

If @scottwernervt shows some activity here I'll put up an MR, but for now I've just been installing cloudstorage as a git dependency - using poetry that'd look like this: 

[tool.poetry.dependencies]
cloudstorage = {git = "https://github.com/zevisert/cloudstorage.git", rev="a9159695b0074e4ede9cb9525f0aaeddc98269d3", extras = ["local", "google"]}

Thank you for sharing and caring. Maybe we should establish an working fork here.