Added byte buffer for reading ouptut pipe

scottwinkler / terraform-provider-shell

Terraform provider for executing shell commands and saving output to state file

Mozilla Public License 2.0

279 stars 61 forks source link

Added byte buffer for reading ouptut pipe #10

Closed millmakerjm closed 5 years ago

millmakerjm commented 5 years ago

Data is read in chunks of 8K and merged into one bytes.Buffer so shell script can now output JSON structures larger that 8K.

scottwinkler commented 5 years ago

Nice work! This is a great addition. But can you please add an acceptance test for this? I just merged a commit to add some basic tests so you have a pattern to work with. You can run the tests with make test