scottwinkler
commented
4 years ago I usually use TF_LOG=debug to be able to get error messages and this is consistent with the behavior of all other Terraform providers. I understand, however, that this provider is unique in that in lets you incorporate custom shell scripts. I think it may be useful to add a configuration variable to the provider to output messages regardless. I will consider adding this as a feature, and leave this ticket open until then. In the meantime, if you want output values without having debug on, then simply return it as part of the json payload and set it as a Terraform output value.
For the nonzero status value, I am not sure why you would be experiencing that problem. I believe I fixed that in a previous release. In the utility.go file, here is the code that runs the shell script and outputs results:
log.Printf("[DEBUG] shell script command old state: \"%v\"", state)
// Output what we're about to run
log.Printf("[DEBUG] shell script going to execute: %s %s \"%s\"", shell, flag, command)
// Run the command to completion
err = cmd.Run()
pw.Close()
log.Printf("[DEBUG] Command execution completed. Reading from output pipe: >&3")
//read back diff output from pipe
buffer := new(bytes.Buffer)
for {
tmpdata := make([]byte, maxBufSize)
bytecount, _ := pr.Read(tmpdata)
if bytecount == 0 {
break
}
buffer.Write(tmpdata)
}
log.Printf("[DEBUG] shell script command stdout: \"%s\"", stdout.String())
log.Printf("[DEBUG] shell script command stderr: \"%s\"", stderr.String())
log.Printf("[DEBUG] shell script command output: \"%s\"", buffer.String())
if err != nil {
return nil, fmt.Errorf("Error running command: '%v'", err)
}as you can see, it not only outputs the previous state, but the commands it is about to run, and the stdout, stderr and (3) output. Only after outputting these does it check if there was an error and then fail. So you should be getting output messages if you have debug on.
adudek
jemc
ppff
lukasmrtvy
As part of my lifecycle scripts I'd like to have the ability to print messages that will actually be shown to the user running Terraform.
For example, when running
kubectl applyon a set of manifests I'd like to be able to show the individual resources getting created / being unchanged / etc.Currently, I can inspect the output of the lifecycle commands using
TF_LOG=debug, but that also prints a bunch of other verbose messages from Terraform and from the plugin that I dont' want to see.I can understand that some people want the output of their commands to be hidden when not in debug mode, but I'd appreciate a way to present curated output. Maybe the provider could be modified to always print the contents of ether stdout or stderr (while hiding the other)? Or if you want to keep backwards compatibility, maybe you could open a new file descriptor for writing to the Terraform output (4?)
Somewhat separately, but somewhat related (let me know if you'd prefer to discuss in a different ticket), when a lifecycle command fails, I only see the nonzero exit status printed from terraform, but it would be nice to also see further information for troubleshooting purposes, like the stdout/stderr of the program, and possibly also the state it received as input.