Adding a max request size restriction for endpoints

scotty-web / scotty

Haskell web framework inspired by Ruby's Sinatra, using WAI and Warp (Official Repository)

http://hackage.haskell.org/package/scotty

BSD 3-Clause "New" or "Revised" License

1.72k stars 134 forks source link

Adding a max request size restriction for endpoints #278

Closed hotlib closed 3 years ago

hotlib commented 3 years ago

This commit adds the following:

a maxRequestSize function to set max request size
RouteOptions where different global scotty options could located (max-size, rate etc.)
ScottyState is extended by RouteOptions so it is available when processing requests

Commit does not break existing API and is backwards compatible.

Trying to address issue #203

fumieval commented 3 years ago

I think this looks good. It would be nice if someone else could skim through the changes too -- @RyanGlScott or @friedbrice ?

friedbrice commented 3 years ago

taking a look right now.

On Jun 6, 2021, at 3:20 AM, Fumiaki Kinoshita @.***> wrote:

I think this looks good. It would be nice if someone else could skim through the changes too -- @RyanGlScott https://github.com/RyanGlScott or @friedbrice https://github.com/friedbrice ?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/scotty-web/scotty/pull/278#issuecomment-855374624, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAZGE45D76T3BIHSWWDR6XDTRNDXFANCNFSM45NEN7UQ.

hotlib commented 3 years ago

Thank you very much for adding this, @hotlib. I have some requests that are mostly about API consistency and code style. If you don't have time for that, let me know and I'll take care of them.

Thanks again!

@friedbrice thank you for the review! I made some changes based on your suggestions (which were all valid), if you have anything, or you don't like the changes I've done now, please let me know, so that I can improve the PR further :)

friedbrice commented 3 years ago

(Still not sure how we want to manage our process for this repo. I'll let this simmer for a few hours in case anybody else wants to make any comments, then I'll merge it.)