Closed friedbrice closed 2 years ago
I haven't tested this beyond a "hello world" app, but Scotty builds with the appropriate patches to its dependencies. Right now the dependencies which need a GHC 9.2 patch uploaded to hackage are:
It's unclear why these PRs have not been merged.
I can build a project dependent on Scotty using this cabal.project
to forcibly use the patched dependencies:
packages: .
-- Patches to build with GHC 9.2.1; remove these when official builds are released.
source-repository-package
type: git
location: https://github.com/tfausak/hs-memory
tag: 3cf661a
source-repository-package
type: git
location: https://github.com/TomMD/foundation
tag: 0bb195e
subdir: foundation basement
source-repository-package
type: git
location: https://github.com/josephcsible/cryptonite
tag: 3b081e3ad027b0550fc87f171dffecbb20dedafe
I can build a project dependent on Scotty using this
cabal.project
to forcibly use the patched dependencies:
I think that https://github.com/josephcsible/cryptonite is rebased, therefore:
source-repository-package
type: git
location: https://github.com/josephcsible/cryptonite
tag: 0d04e90dc33b6aeaf8a5686921d6999599429fb0
i will look into this when i get home. i’d prefer not to depend on off-hackage commits, though.
Sent from my iPhone
On Mar 12, 2022, at 6:17 PM, Vehbi Sinan Tunalioglu @.***> wrote:
I can build a project dependent on Scotty using this cabal.project to forcibly use the patched dependencies:
I think that https://github.com/josephcsible/cryptonite is rebased, therefore:
source-repository-package type: git location: https://github.com/josephcsible/cryptonite tag: 0d04e90dc33b6aeaf8a5686921d6999599429fb0 — Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android. You are receiving this because you were assigned.
i’d prefer not to depend on off-hackage commits, though.
I totally agree. I was just testing 9.2 in general.
Oh! I understand. Sorry for the confusion on my part!
On Mar 12, 2022, at 10:24 PM, Vehbi Sinan Tunalioglu @.***> wrote:
i’d prefer not to depend on off-hackage commits, though.
I totally agree. I was just testing 9.2 in general.
— Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android. You are receiving this because you were assigned.
No problem at all.
Btw: I understand that the 3 libraries mentioned have new releases now. I managed to compile a "hello world" Scotty (v0.12) application with stock dependencies the way cabal has resolved them (without pinning to off-hackage commits). That should be good news.
Scotty is now in Stackage LTS 19.2 (on GHC 9.0.x) and Stackage Nightly (on GHC 9.2.x), so I'll close this issue. Thank you very much, @jamestmartin and @vst, for doing the prep work to make sure that builds would go smoothly ahead of Stackage! Your help is appreciated, and it made sure we could avoid getting into a rushed situation if, say, the build failed on these GHC versions for some reason and we only learned about it when Stackage incremented its GHC. Thanks again!
and publish to Hackage once it's working.