scotty-web / scotty

Haskell web framework inspired by Ruby's Sinatra, using WAI and Warp (Official Repository)
http://hackage.haskell.org/package/scotty
BSD 3-Clause "New" or "Revised" License
1.72k stars 134 forks source link

[RFC] Support the latest versions of GHC #289

Closed friedbrice closed 11 months ago

friedbrice commented 1 year ago

This is a tentative PR. I'd like to merge it, but I'm not adamant. This PR eliminates almost all CPP, closing https://github.com/scotty-web/scotty/issues/252. (Some CPP is kept around for gating certain tests by platform support.)

So, I'd like to tackle some of the Issues, such as https://github.com/scotty-web/scotty/issues/262, https://github.com/scotty-web/scotty/issues/258, and https://github.com/scotty-web/scotty/issues/272, and I would need to smooth out and simplify project maintenance before doing so.

I'd like to hear what thoughts @scotty-web/admins, @fumieval, @RyanGlScott, and other interested parties have about the following changes.

fumieval commented 1 year ago

It might be too late, but it would be nice to separate code style changes at least

friedbrice commented 1 year ago

@fumieval good call. i can easily split them out :-)

ocramz commented 12 months ago

good call. i can easily split them out :-)

Hi @friedbrice , would you be able to move this forward so we do one last review and merge? Thank you!

ocramz commented 11 months ago

Let's have separate PRs for linting and functional changes in the future.