search

scotty-web / scotty

Haskell web framework inspired by Ruby's Sinatra, using WAI and Warp (Official Repository)
http://hackage.haskell.org/package/scotty
BSD 3-Clause "New" or "Revised" License
1.72k stars 134 forks source link

Allow building with `base-compat-batteries-0.13.*` #292

Closed RyanGlScott closed 1 year ago

RyanGlScott commented 1 year ago

Very strangely, GitHub's UI appears to prevent me from merging this PR:

github

Any idea what is going on here?

RyanGlScott commented 1 year ago

Some further investigation reveals that the scotty repo has enabled the "Lock branch" option for the master branch, which prevents users from pushing to the branch at all (by pull request or otherwise). For the life of me, I can't imagine why this option would ever be useful for the master branch. There is a separate "Require pull request reviews before merging" option that is also enabled for master, which I believe more closely matches what was actually intended here.

I've opted to disable the "Lock branch" option and keep the "Require pull request reviews before merging" option. If this isn't what you want, please speak up. (And I apologize for disrupting your workflow if that is the case!)