scotty-web / scotty

Haskell web framework inspired by Ruby's Sinatra, using WAI and Warp (Official Repository)
http://hackage.haskell.org/package/scotty
BSD 3-Clause "New" or "Revised" License
1.72k stars 134 forks source link

add Web.Scotty.Cookie #293

Closed ocramz closed 1 year ago

ocramz commented 1 year ago

addresses #253

cc @chessai ^^

chessai commented 1 year ago

this LGTM

Can you add tests?

ocramz commented 1 year ago

I don't understand why is CI failing ; I've built thir PR successfully with GHC 9.2.7

ocramz commented 1 year ago

I was afraid I would have to pull webdriver out but we have hspec-wai :)

ocramz commented 1 year ago

Tests added @chessai ^^ LMK

ocramz commented 1 year ago

@fumieval we now import 'cookie' and re-export some of its definitions.

ocramz commented 1 year ago

Hi @fumieval , could you merge this if there are no more questions?

chessai commented 1 year ago

Just triggered CI, if it passes I'll merge

ocramz commented 1 year ago

CI failures are most puzzling. I did introduce two new dependencies in this PR (cookie and time), and perhaps the lower bounds need to be relaxed (even though neither of them is mentioned in the CI failures). I've only tested this PR with stack, I don't use cabal

ocramz commented 1 year ago

@fumieval I've gotten rid of some unnecessary imports in one of the example binaries. Hopefully now CI will be green at least for the recent GHCs. I really don't know why don't older GHCs work

ocramz commented 1 year ago

The CI failure for 8.6.5 seems to be due to a change in a recent version of 'wai-extra' which now imports 'crypton-x509' instead of 'x509'

https://github.com/scotty-web/scotty/actions/runs/5282948607/jobs/9564762917?pr=293#step:17:61

The failures on GHC <= 8.0.2 are still mysterious to me

fumieval commented 1 year ago

I think it's fine to drop support for GHC < 8.10 (there's #289 too). Thoughts? @chessai @RyanGlScott

ocramz commented 1 year ago

Can I do something to get this PR across the finish line?

chessai commented 1 year ago

I think it's fine to drop support for GHC < 8.10 (there's #289 too). Thoughts? @chessai @RyanGlScott

Fine by me