Do not export Web.Scotty.Internal.Types ?

scotty-web / scotty

Haskell web framework inspired by Ruby's Sinatra, using WAI and Warp (Official Repository)

http://hackage.haskell.org/package/scotty

BSD 3-Clause "New" or "Revised" License

1.71k stars 132 forks source link

Do not export Web.Scotty.Internal.Types ? #319

Closed ocramz closed 7 months ago

ocramz commented 9 months ago

It's an internal module, most of its interesting functionality is re-exported by .Trans and .Scotty, and some invariants would be better served by not offering the constructors to the users.

fumieval commented 9 months ago

In general I prefer to keep internal modules exported. Internal modules provide a mean to complement features missing in the library.

ocramz commented 7 months ago

OK, closing this no worries