Is MonadReader ActionEnv (ActionT m) a good idea?

scotty-web / scotty

Haskell web framework inspired by Ruby's Sinatra, using WAI and Warp (Official Repository)

http://hackage.haskell.org/package/scotty

BSD 3-Clause "New" or "Revised" License

1.72k stars 134 forks source link

Is MonadReader ActionEnv (ActionT m) a good idea? #342

Closed fumieval closed 11 months ago

fumieval commented 11 months ago

I noticed that I have to lift all asks in my code because I'm using RIO as a base monad of ActionT. Given that ActionEnv is an internal structure, inheriting the MonadReader instance of the base monad seems more convenient (also brings back the pre-0.20 behaviour).

ocramz commented 11 months ago

your proposal makes a lot of sense.