URL-decoding query and form parameters + decoding `FormData`

scotty-web / scotty

Haskell web framework inspired by Ruby's Sinatra, using WAI and Warp (Official Repository)

http://hackage.haskell.org/package/scotty

BSD 3-Clause "New" or "Revised" License

1.71k stars 132 forks source link

Closed pbrinkmeier closed 2 months ago

pbrinkmeier commented 3 months ago

Hiya, first time contributor.

This PR adds

Let me know if this looks good to you guys or if I need to change anything.

closes #321 , closes #170 .

ocramz commented 3 months ago

thank you @pbrinkmeier ! I'll take a look soon.

pbrinkmeier commented 3 months ago

I added the changelog entry

pbrinkmeier commented 3 months ago

Fixed the conflict in changelog.md

pbrinkmeier commented 3 months ago

I am still not entirely sure how to go forward with formData. Should I just remove it or rewrite it in terms of formParams?

ocramz commented 3 months ago

I think rewriting it in terms of formParams would be a great way forward!

ocramz commented 2 months ago

@pbrinkmeier looks good but why do we need the 'reverse' in 'paramListToForm'? the data comes from a hashmap anyway. Or am I missing something?