scottyab / rootbeer

Simple to use root checking Android library and sample app
Apache License 2.0
2.48k stars 440 forks source link

Is selinux flag giving a false positive? #183

Closed test-pad closed 1 month ago

test-pad commented 3 years ago

Hi. I have a Samsung note 20 ultra. I am not sure why rootbeer sample app indicates that my phone is rooted. My phone is not rooted.

I have used other apps like root checker, advanced root checker and root beer fresh and all indicate my phone is not rooted.

May I know if there are ways to check if there is a bug or there are something that is causing the false positive? Some screenshots below for your reference.

Thank you very much.

Screenshot_20210917-072615_RootBeer Sample.jpg

Screenshot_20210917-072639_Settings.jpg

Screenshot_20210917-072708_Settings.jpg

ghost commented 2 years ago

There are old issues talking about this: https://github.com/scottyab/rootbeer/issues/179

Looks like no one maintains the project any more

scottyab commented 2 years ago

Hey @grubeli sorry it feels that way. Merged your PR thanks for the contribution.

roshaan-sadapay commented 2 years ago

@scottyab when you guys are gonna release this version?

ale5000-git commented 2 years ago

@scottyab Reading over the internet I have found that ro.build.selinux is unreliable, it may be 0 and still SELinux is enforced or it may also be missing completely.

It is more reliable to execute /system/bin/getenforce that return Enforcing, or read /sys/fs/selinux/enforce that return 1.

See also here: https://erev0s.com/blog/3-ways-detect-selinux-status-android-natively/

mohamedebrahim96 commented 2 years ago

@ale5000-git

Could you please fix the code in pull request so that lib owner can merge

malikzype commented 1 year ago

Facing same issue. False Positive @ale5000-git Can you help?

agnostic-apollo commented 1 year ago

@scottyab You may wanna check https://github.com/kdrag0n/safetynet-fix/pull/166#issuecomment-1509789489 and remove the check altogether.

HuskyDG commented 1 year ago

this detector is dead

VD171 commented 7 months ago

Selinux is returning a false positive.

scottyab commented 1 month ago

We have removed the Selinux method in 0.1.1 given it's not accessible on later versions of Android and is not "truly" an isRooted indicator. Thanks for flagging this issue.