search

scottyab / rootbeer

Simple to use root checking Android library and sample app
Apache License 2.0
2.5k stars 442 forks source link

Why Is the Native Check Limited to SU Binary Only? #227

Open qorzi opened 4 months ago

qorzi commented 4 months ago

Hello, I am a beginner developer and I have a question.

Regarding the native check items, is there a specific reason why only the su binary is checked? When looking at the code structure, it seems like it would be easy to add checks for busybox or magisk binaries as well. I am curious why only the su binary undergoes additional checks.

scottyab commented 3 months ago

Thanks for the question. Initially su was deemed the more imported binary to check for but we could certinaly add the ability to check for other binaries via the native check.