search

scottyab / rootbeer

Simple to use root checking Android library and sample app
Apache License 2.0
2.5k stars 442 forks source link

Failed to promote to production on Maven Central due to missing sources #236

Closed scottyab closed 2 months ago

scottyab commented 2 months ago

Describe the bug/feature request/question

I'm getting the following error when attempting to close the published 0.1.1 item to promote to production.

maven central Event: Failed: "Sources Validation" Missing: no main jar artifact found in folder

image

Snapshot publishing seems to work aok, see here.

Currently looking into this but posting here for visibility.

scottyab commented 2 months ago

Pom packaging was jar but should be aar - thanks to Niall for spotting this

NityaSantosh26 commented 2 months ago

@scottyab, Thanks for releasing 0.1.1. But I still can't use the latest version and here is the log from jitpack.io. There's some gradle task failing. https://jitpack.io/com/github/scottyab/rootbeer/0.1.1/build.log

scottyab commented 2 months ago

Hey @NityaSantosh26 so we seem to have broken jitpack.io builds with the move to the gradle built-in maven publishing support as now the signing details are required for release builds. This isn't a bad thing per se and to me, it seems this is better from a security/authenticity point of view - but sorry if this has broken your build.

Can you drop jitpack.io in favour of Maven Central? you might need to reorder them in your repository definition.

If not then maybe you can reopen and rename #235 as "Jitpack.io releases are no longer supported since 0.1.1" and we look to prioritise this if more people flag this as an issue.