search

scottyab / rootbeer

Simple to use root checking Android library and sample app
Apache License 2.0
2.47k stars 440 forks source link

Crash on root native check #52

Closed MPeti1 closed 7 years ago

MPeti1 commented 7 years ago

I set rootcloak to hide root things from rootbeer sample app, and then the app crashes at root native check. Notice: rw paths successfully detected. OTP Smartbank app (Hungary) uses this root checking library, and it also crashes. Also, if i dont use rootcloak for smartbank, then it will not launch... I bet the Hungarian OTP team not going to update the library in their app, so can you give me a quick fix how can i bypass the detection in an old version? You know, old versions not supported.. Me and many other users of the app thinks that OTP wants to decide if we want to use root, and it's a bad behavior.

Anyway, here is the log (OTP Smartbank crash when checking for root if rootcloak tries to hide it): And a video (about the crashing sample app)

ghost commented 7 years ago

Did this crash occur on the latest release build, the latest master branch, or on another build?

MPeti1 commented 7 years ago

Sorry, i don't know :/ I'm not a developer of the app, i only wanted to use it in my rooted phone. If you can provide a method to see it, i can provide it to you. Maybe if i decompile the app?

stealthcopter commented 7 years ago

As @MPeti1 suspects this is likely caused by an outdated version of the library included in the app in question. The library no longer crashes if the native root checking library cannot be loaded, but I think we still need to update the sample app on the Play store. The Hungarian OTP team should update the library used so they can provide better UX for when root is detected or suspected rather than just crashing.

Also as we are the ones attempting to detect root we aren't really the best people to ask how to bypass our own work ;)

ghost commented 7 years ago

This was an issue that I fixed in the latest master. Once the next release of rootbeer is out, this will be fixed.