search

scottyab / secure-preferences

Android Shared preference wrapper than encrypts the values of Shared Preferences. It's not bullet proof security but rather a quick win for incrementally making your android app more secure.
1.53k stars 235 forks source link

Fix getAll method to return the correct value for StringSet. #100

Closed samratshaw closed 5 years ago

samratshaw commented 5 years ago

The current implementation of getAll returns hashed keys & decrypted values (as Strings).

However, it does not return values correctly when the stored type is a Set.

For migration to Android Q, it is important that we get all the decrypted values that are stored in the list & migrate using our own salt.

samratshaw commented 5 years ago

I have created a PR #99 to fix this issue. Please considering merging the same & making a new release.

scottyab commented 5 years ago

Thanks @footyapps27, you're a ⭐️