Closed zeeshanasghar closed 5 years ago
@scottyab there might be self assignment issue too at https://github.com/scottyab/secure-preferences/blob/master/library/src/main/java/com/securepreferences/SecurePreferences.java#L173
@zeeshanasghar Thanks for your contributions. I'll ensure these are added but likely not part of this PR and instead part of the re-write.
This pull request is focused on resolving occurrences of Sonar rule
squid:S2786 Nested 'enum's should not be declared static squid:S2325 'private' methods that don't access instance data should be 'static' squid:S1854 Dead stores should be removed squid:S1481 Unused local variables should be removed
You can find more information about the issue here: https://dev.eclipse.org/sonar/rules/show/squid:S2786 https://dev.eclipse.org/sonar/rules/show/squid:S2325 https://dev.eclipse.org/sonar/rules/show/squid:S1854 https://dev.eclipse.org/sonar/rules/show/squid:S1481
Please let me know if you have any questions.
Zeeshan Asghar