search

scottyhardy / docker-remote-desktop

Docker image for Remote Desktop server with audio support
MIT License
251 stars 128 forks source link

add browser and git #3

Closed mhmh55516 closed 4 years ago

mhmh55516 commented 4 years ago

Hi can you add firefox browser ?! Thank you

mhmh55516 commented 4 years ago

and add chromium-browser please

mhmh55516 commented 4 years ago

and add git

scottyhardy commented 4 years ago

Hi @mhmh55516

All these requests are simple enough and I think others would find value in having a browser and git - although I’ll add them to the docker-remote-desktop base image. I’d prefer just a single browser to keep the size down though - I’m thinking Chromium may be better due to Flash support without needing a separate flash add-on. Let me have a play and I’ll make a decision.

scottyhardy commented 4 years ago

I ended up going with Firefox as it's the most common browser for Linux and Chromium is provided by snapd package manager which I couldn't get to work. I'm not including Flash plugin due to it nearing end of support.

I'll need to update the docker-wine script to include --shm-size="1g" to the docker run command, otherwise Firefox tabs continually keep crashing. I'll get that updated once I've pushed out the updated images.

mhmh55516 commented 4 years ago

you can run Chromium with this command "chromium --no-sandbox"

scottyhardy commented 4 years ago

The issue was when trying to install chromium during a build it kept failing to contact the snap server. I originally used apt-get install and also tried installing snapd and using snap install but both methods failed so I stopped there.

scottyhardy commented 4 years ago

Hi @mhmh55516

This issue's been resolved now and I've tested to ensure the downstream docker-wine image includes Firefox and git. Thanks for the feedback and suggestions 😄