search

scoumbourdis / grocery-crud

Grocery CRUD is a PHP Codeigniter Framework library that creates a full functional CRUD system without the requirement of extra customisation to the JavaScripts or the CSS to do it so.
http://www.grocerycrud.com
GNU General Public License v3.0
1.01k stars 472 forks source link

When using unset_edit_fields these fields disappear from the read page #238

Open davidoster opened 11 years ago

davidoster commented 11 years ago

There has being a question about this here: http://www.grocerycrud.com/forums/topic/2015-unset-edit-fields-and-read-fields

Looking at the code, protected function showReadForm($state_info), line 1841 $data->fields = $this->get_edit_fields();

gets the read fields from the edit_fields. I believe it shoud be either from the columns or when full developed the read feature have the equivalent get_read_fields.

scoumbourdis commented 11 years ago

You are right :-( . I never thought about this issue. I will have it in mind so I can fix it.

Thanks Johnny

Nagasir commented 10 years ago

was it fixed ?? i have that problem too

gulariav commented 10 years ago

It is not fixed yet :(

arif-rh commented 10 years ago

It's has been fixed six months ago, check this 59f6545ac22533fc8905c35267d4f5fb2e1f27bf

gulariav commented 10 years ago

Apologies, but it seems there is some differences in both files. I am using library package from website ( https://github.com/scoumbourdis/grocery-crud/archive/v1.4.1.zip ).

but the commit you mentioned is fixed. Thanks buddy :) :+1:

luiscoms commented 10 years ago

There is no verion contron on the site. With some bugfixes the good pratice is create a new tag.