search

scour-project / scour

Scour - An SVG Optimizer / Cleaner
Apache License 2.0
770 stars 60 forks source link

Check xlink:href for gradientUnits="userSpaceOnUse" #271

Open nthykier opened 3 years ago

nthykier commented 3 years ago

When considering to prune attributes set to a default values, we checked the gradientUnits attribute first to determine if that was valid. Unfortunately, we omitted to check whether the gradientUnits attribute was inherited via xlink:ref. This commit corrects that bug.

Closes: #225 Signed-off-by: Niels Thykier niels@thykier.net

codecov-io commented 3 years ago

Codecov Report

Merging #271 (e0e3f81) into master (fbf0c06) will decrease coverage by 0.03%. The diff coverage is 91.30%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #271      +/-   ##
==========================================
- Coverage   94.08%   94.05%   -0.04%     
==========================================
  Files           6        6              
  Lines        2264     2286      +22     
==========================================
+ Hits         2130     2150      +20     
- Misses        134      136       +2
Impacted Files Coverage Δ
scour/scour.py 94.50% <91.30%> (-0.04%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update fbf0c06...e0e3f81. Read the comment docs.