scoursen / django-softdelete

Soft delete for Django ORM, with support for undelete.
Other
376 stars 102 forks source link

Tests not working with Django 3 #84

Open TAnas0 opened 2 years ago

TAnas0 commented 2 years ago

I am using:

Running the tests, as instructed in the Readme django-admin.py test softdelete --settings="softdelete.settings" results in the following error:

...
from django.shortcuts import render_to_response, get_object_or_404, redirect
ImportError: cannot import name 'render_to_response' from 'django.shortcuts'

It's a compatibility issue with Django 3 which was resolved in this PR https://github.com/scoursen/django-softdelete/pull/77 When I install the latest commit using pip the tests run fine. So I guess this is more of an issue about publishing the latest changes to PyPi. Maybe it's time for a major version :slightly_smiling_face:

Somewhat related issues:

TAnas0 commented 2 years ago

@scoursen And BTW, I can help you setup a CI pipeline that deploys to PyPi on Github releases (or something similar) if need be