search

scoursen / django-softdelete

Soft delete for Django ORM, with support for undelete.
Other
376 stars 102 forks source link

New PyPi release needed to stop generating migrations files for package #89

Closed antsankov closed 2 years ago

antsankov commented 2 years ago

In the latest release of django-softdelete, 0.9.3 -- Django makemigrations is generating a migration file for the softdelete package itself.

Based on this PR https://github.com/scoursen/django-softdelete/pull/88 (merged a week ago) it changes the default ID generation, so that a migration file is no longer generated

A release of the current master branch to PyPi should solve this issue.

Example:

$ ./manage.py makemigrations
Migrations for 'softdelete':
  /usr/local/lib/python3.8/dist-packages/softdelete/migrations/0004_alter_changeset_id_alter_softdeleterecord_id.py
    - Alter field id on changeset
    - Alter field id on softdeleterecord
PeterCarnesciali-minted commented 2 years ago

Yes, please make a new release so we can use that fix.

scoursen commented 2 years ago

I think it's been uploaded to pypi correctly.

antsankov commented 2 years ago

Can confirm this works FYI - thank you!