Open itsderek23 opened 6 years ago
Note I haven't tested Flask yet.
The naming logic for Flask looks the same:
Our endpoints are named app.routes.boom
, so the same approach would apply for Flask.
For all the Python integrations we do tag with the request path already ( e.g. https://github.com/scoutapp/scout_apm_python/blob/c5fb9f2b26cad3c3ec40970b0dfc3c0bc566be64/src/scout_apm/django/middleware.py#L18 / https://github.com/scoutapp/scout_apm_python/blob/c5fb9f2b26cad3c3ec40970b0dfc3c0bc566be64/src/scout_apm/flask/__init__.py#L66 ) so maybe that's of use?
We're able to display Sentry errors for Django apps under the App Overview:
...but not under specific endpoints. Sentry appears to name an issue's associated
transaction
based on the request path:https://github.com/getsentry/raven-python/blob/e52c837859d4fbeafdd2bdfa7dc6331a953ca77f/raven/contrib/django/client.py#L308
Also:
We name our web endpoints based on the Django view name (ie
/hello.views.posts
).This is different than Sentry's Rails conventions.
One option: provide an an additional integration step for Sentry, instructing the user to add a custom tag w/key=
django_view
and the name = the view name.Note I haven't tested Flask yet.